Contributors mailing list archives
Re: Code audit in maintainer-toolsby
Tecnativa. S. L., Pedro M. Baeza
You can use https://github.com/OCA/maintainer-quality-tools/tree/master/git to set a pre-commit check in GIT.Regards.
2016-12-06 5:53 GMT+01:00 Jean-Charles Drubay <firstname.lastname@example.org>:
Thanks Pedro, David and Moises.It helped me a lot to get started.As a new attempting contributors of maintainers quality tool, I found it a bit difficult / impossible to pass all the checks from travis. (in the PR you can see the difficulties I encountered: https://github.com/OCA/
maintainer-quality-tools/pull/) 382Do you think there could be a documentation somewhere to explain how to test locally to avoid the need of committing/push to OCA to get travis results?I started to share my tricks here: https://github.com/OCA/ maintainer-quality-tools/pull/ 380Regards,Jean-CharlesOn Thu, Oct 27, 2016 at 12:07 AM, Moises Lopez <email@example.com> wrote:Currently we have static checkers (without install the module) with a custom extension for odoo of pylintMaybe you are interest in follow the project: https://github.com/oca/pylint- odoo2016-10-26 6:53 GMT-05:00 Jean-Charles Drubay <firstname.lastname@example.org>:Hello,I just read the contribution guidlines and was impressed by how well documented the rules are. :)Also, I remember that long time ago (up to 6.1), there was a module named base_module_quality that could audit the source code and find all the non-compliance point based on coding guidlines.Is there some equivalent tool today?If there is none, I guess it would make sense to have it as a command in maintainer-tools: oca-code-review which could audit the code without the need of installing the related module. Maybe we can help with that.Thanks,Jean-Charles--