Contributors mailing list archives
Re: Company as maintainerby
Sicurpharma Srl, Francesco Foresti
I agree with you Stéphane,
to address also Pedro's concerns: while merging rights for minor changes can be useful to have, it's always convenient to get a PSC review to make sure the change is done correctly.
The main point of this is keeping track with proposed changes to modules we have developed, migration to other versions, and to be contacted in case there's any request about them.
I will ping you in a PR to check whether it works
Il giorno ven 28 ott 2022 alle ore 10:07 Stéphane Bidoul <email@example.com> ha scritto:
That said, even if that works, we need to be careful with this, as we would not want the maintainers key to become a marketing device for companies.-sbiOn Thu, Oct 27, 2022 at 5:04 PM Stéphane Bidoul <firstname.lastname@example.org> wrote:Hi Francesco,What you put in the maintainers key must be valid GitHub handles.It may work if you put both a team of your company (to receive notifications) and a user of your company (to get permissions to ocabot merge).Can you try and ping me on the PR so I can follow the process?-sbiOn Thu, Oct 27, 2022 at 4:47 PM Francesco Foresti <email@example.com> wrote:Thanks Pedro,what I meant was either:- assigning a "companyname" github account as maintainer of the module, or- both "companyname" and "devname" as maintainers.I don't think there's any issue in having multiple maintainers of a module?Cheers
FrancescoIl giorno gio 27 ott 2022 alle ore 16:32 Pedro M. Baeza <firstname.lastname@example.org> ha scritto:The problem is that all checks go through the GitHub user, so there's no notion of other grouping form (like GitHub organizations) that allows that. It would be interesting, but it should be implemented. The per user approach is also for not having noise in mid-size organizations.Regards.--Francesco ForestiSicurpharma Srl+39 333 8123 790
+39 333 8123 790