Contributors mailing list archives

Browse archives


Re: Proposing myself as l10n-spain PSC

Landoo SL, Aritz Olea
- 14/07/2022 15:12:58
Hi all,

Pedro, even if I were PSC I would not merge PRs of modules I don't know enough. I think it's more efficient having more PSCs specialized and motivated in some modules than trying to have someone specialized in all of them.

Thanks Graeme and Sylvain for your feedback. Sylvain, I didn't know the information you sent about the merge right of the module maintainers. This can be really helpful for us. If I don't get Pedro's approval, this can be a good solution for the Basque modules.


El jue, 14 jul 2022 a las 14:56, Sylvain LE GAL (<>) escribió:
Hi Graeme,

some precision inline.

Sylvain LE GAL - Twitter
GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)
Site Web | FramaSphere | Facebook
3 Grande rue des Feuillants, 69001 Lyon
Standard : (+33)
Service Informatique : (+33)
Astreinte Informatique : (+33)
Member of the OCA (Odoo Community Association)

Le jeu. 14 juil. 2022 à 14:36, Graeme Gellatly <> a écrit :
Hi Josean,

You raise an interesting point and part of this is how different repos evolved. We are starting to see a kind of natural split between a PSC with I suppose a high level view of a repository's purpose, strategy, inclusions exclusions etc and maintainers with specific module knowledge as repositories get larger. However, there is a tension that maintainers cannot merge even the code they maintain, but PSC's can. For me, long term the solution is merge rights for maintainers for the modules they maintain.

- a developer has merge right on github for a PR if declared maintainers in the manifest of the modified module(s) for the current branch. That feature has been enabled since 3 years. (Ref.)
- a developper has also merge right on github for a PR if declared maintainer in the manifest of the modified module(s) for any branch. (past or future). That feature has been enabled since 3 monthes. (Ref)

Indeed, this is how almost all other opensource works. I know people with much more knowledge than me are working on this. But in this case, it may make more sense for a separate repository anyway. In fact maybe it makes sense for a lot of repos.

But also there are very many workarounds to a short term merge problem, and in a code sprint it often makes more sense to work separately anyway just for CI time, although maybe this no longer applies. I don't know the Spanish localisation at all, but FWIW the idea that fiscal specific code is going to be merged inside of two days into what is a very long lived and presumably stable repo is the opposite of a good reason.  In fact, I thought the policy was 5 days after 2 approved reviews to allow any objections unless some good reason to override. Maybe I'm wrong, those principles have changed over time.

On Thu, Jul 14, 2022 at 10:52 PM Josean Soroa - Landoo <> wrote:
Hi all.
Excuse me for this long answer but the question is very important for us.
My vote is +1 for Aritz.

My reasons are very similar to the case of Pablo:
- I believe in our l10n-spain repo, we shoudn't restrict PSCs to those with deep knowledge of all 39 modules. Selected PSCs should be professionals with enough experience on OCA contribution rules and aware of its limitations. They have to review and merge only modules within their area of expertise.
- I know him as a serious and responsible professional. I'm sure he is not going to merge PRs outside his expertise.
- Aritz is one of the few developers who knows deeply Basque Country localization

In are more deep explanation, I'm involved in this question by 3 different rules.
- As President of Aeodoo I'm trying to boost spanish localization and I believe that one of the mistakes in spanish community is the very small number of PSCs
From last year Urtzi (from Coninpe) is the member of the board of Aeodoo leading with spanish localization and results are very hopeful. Just see "Mentoring project". Hi has a very good vision on this point and is asking for more PSCs.
- As member of "Basque Country localization team", I'm actively working to add specific Basque fiscal requirements (basically Ticketbai). Leader of this team is Victor (from Kernet) and this days is in holidays, so I speak in his name. We are planning to proceed with two code sprints on this july and we need enough PSCs to not stop the development of this window. In this team we are 10 companies with a compromise of at least 2 resources dedicated to this activities, each one (so 20 people). Objective is to have all our needed developments from v13 to v15 at the end of July. This is not possible if we have to wait to much for merge. Take note that we are speaking about 5 modules x 2 versions (14 and 15) = 10 PRs with their approvals and merges.
This is too much work in a windows of 2 days for only one or two PSCs and they need good knowledge about Basque fiscality. None of actual PSCs is involved directly in this developments.
- As contributor I see other questions. For example, in Italy they have 9 PSCs (as explained by Sergio Corato in this mailing list). All of them are fully skilled in their 54 modules? I'm sure they're not. But I'm sure each one of them only merges modules that they know enough.

I hope other members of the community will agree with this point of view and will send a +1 to this applicant.

Josean Soroa

El mié, 13 jul 2022 a las 11:32, Pedro M. Baeza (Tecnativa) (<>) escribió:
Sorry, Aritz, your experience in the localization is totally limited to TicketBAI, so for me as PSC representative of l10n-spain is a -1.


Post to:

Post to:

Post to:

Post to:

Aritz Olea
LANDOO - Sistemas de Información con Odoo