Contributors mailing list archives

Browse archives


Re: Reviews

Holger Brunn
- 16/09/2021 14:20:27
> Also, even if there are 2 reviews then PSC's generally don't respond to

> merge requests.

I can tell you why I don't: It has happened quite often in the past that I 
trusted fellow reviewers' reviews, but afterwards it turned out what I merged 
was very obviously wrong - just as you mention below we do have quite a bit of 
substandard code already in the codebase. And I feel responsible for what I 
merge. So if the existing reviews are not done by (to me) "known good" 
reviewers, I'll only merge if I reviewed myself too, and that is severely 
constrained by lack of time.

In the survey about PSCs earlier (I haven't seen any results of this, will 
those be published?), I wrote that I'd like to have some kind of automated 
triage, this would increase my reviewing/merging output considerably. Very 
often I spend my weekly OCA-time on clicking through PRs that are in my 
opinion of such a low quality that a review would be CS 101 plus guided 
reading of the conventions, and that's simply not what I signed up for.

A bot that closes PRs with failing CI for longer than X days would be a start, 
another bot could close PRs of people who don't play nice (details to be 
determined), inactive PRs should be closed much earlier. Then I know that 
what's left is not a waste of time and go reviewing in a much happier mood.

Your partner for the hard Odoo problems


  • Avatar


    Sunflower IT, Tom Blauwendraat
    - 16/09/2021 13:49:25 - 0

    10 replies 10 replies