Contributors mailing list archives

Browse archives


New module derived from Odoo CE licensing/credits question

Data Dance s.r.o., Radovan Skolnik
- 30/07/2021 13:20:11

I have modified module website_sale_comparison from Odoo CE into website_sale_custom_info_comparison to work with website_sale_custom_info (based on PR from 9.0 by Jairo Llopis - will create PR for 13.0 soon) which uses product_custom_info. The modifications are really minimal: removed some unneeded code and templates (as these are already present in custom_info), rework of method _prepare_categories_for_display of product.product to work with custom info and slight changes to template displaying the comparison table. So basically it is 90% Odoo code, 10% of modifications.

Licensing-vise it should be OK as Odoo is LGPL v3. However my understanding is that original author should be kept there if this was to be included in OCA repository. Any comments on how to do this properly? I mean shoudl I just put Odoo as one of the authors or look up commits to these files in git? Would such module be acceptable for OCA?

Any comments are welcome. Best regards

	Radovan Skolnik